{{ message }}
[stdlib] Fix os.path.join with trailing separator and add regression test#6631
Open
BlueDestination wants to merge 2 commits into
Open
[stdlib] Fix os.path.join with trailing separator and add regression test#6631BlueDestination wants to merge 2 commits into
os.path.join with trailing separator and add regression test#6631BlueDestination wants to merge 2 commits into
Conversation
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Linked issue
N/A — trivial fix
Type of change
Motivation
Fix a bug where
os.path.join()omitted a separator because it checked the wrong variable (pathinstead ofjoined_path).What changed
mojo/stdlib/std/os/path/path.mojo: changedpath.endswith(sep)→joined_path.endswith(sep)in themulti-segment loop of
join().mojo/stdlib/test/os/path/test_join.mojo: added regressiontest
join("path/", "to", "file").Testing
All join tests pass locally, including the new regression case.
Checklist
agreed-upon, or this is a trivial fix that does not need prior
approval
smaller PRs where possible (see
pull request sizes)
./bazelw run formatto format my changesAssisted-by:trailer in my commit message or this PR description (seeAI Tool Use Policy)
Assisted-by: DeepSeek