{{ message }}
skip empty tvs#85
Open
christianseel wants to merge 2 commits into
Open
Conversation
Member
Mark-H
requested changes
Jan 22, 2019
Mark-H
left a comment
Mark-H
left a comment
Member
There was a problem hiding this comment.
Like the idea but needs to be configuration somehow. Ideally defaulting to the current behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From my perspective there is no need to add empty TV values into the extracted content files. This is useful because now after adding a new TV, not every single resource file changes - only those with a value.