{{ message }}
fix(rmcp): use ServerConfig in cancellation test - #1273
Merged
Merged
Conversation
alexhancock
approved these changes
Sep 15, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
#1262 and #1266 were both green on their own branches and merged cleanly, but together they do not compile because of a semantic merge conflict. Since neither diff touched the other's lines, Git merged them without any issues, and
mainended up with a reference to a type that was no longer in scope:ServerConfigis an alias for the same type (pub type ServerConfig = InitializeResult) and is already imported here, so switching to it fixes the build and keeps #1266's intent intact.How Has This Been Tested?
CI
Breaking Changes
None.
Types of changes
Checklist