{{ message }}
Conversation
DaleSeo
marked this pull request as ready for review
September 14, 2026 22:58
DaleSeo
force-pushed
the
DaleSeo/explicit-default-port-origin-entries-reject-brow
branch
from
September 15, 2026 15:20
15b9894 to
4e2a6b6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes #1268.
Motivation and Context
An
allowed_originsentry with an explicit default port, likehttps://client.example:443, rejected the origin that browsers actually send, which isOrigin: https://client.example. So the entry did not work in practice.RFC 6454 treats an omitted port as the scheme's default port, and then removes that default port when serializing the origin. The matcher compared the missing port from the incoming request directly with the configured port. That meant a configured
:443could only match a client that explicitly included the port.The fix resolves the effective port on the incoming origin before comparing it. That means 443 for
httpsand 80 forhttp. The configured side stays unchanged.How Has This Been Tested?
Add tests
Breaking Changes
None
Types of changes
Checklist