Remove unused chatbot stdio context attribute by Kludex · Pull Request #3678 · modelcontextprotocol/python-sdk · GitHub
Skip to content

Remove unused chatbot stdio context attribute - #3678

Merged
Kludex merged 1 commit into
mainfrom
codex/remove-unused-chatbot-stdio-context
Oct 11, 2026
Merged

Kludex merged 1 commit into
mainfrom
codex/remove-unused-chatbot-stdio-context

Conversation

@Kludex

@Kludex Kludex commented Oct 11, 2026

Copy link
Copy Markdown
Member

Summary

Remove the unused Server.stdio_context attribute from the simple chatbot example. The transport is already owned and closed by AsyncExitStack.

Fixes #3654

Checks

  • uv run --frozen ruff check examples/clients/simple-chatbot/mcp_simple_chatbot/main.py
  • uv run --frozen ruff format --check examples/clients/simple-chatbot/mcp_simple_chatbot/main.py
  • Claude Code CLI review: no findings

AI Disclaimer

This PR was developed with the assistance of either Claude or Codex. I've reviewed and verified the changes.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Turn on auto-fix | Re-trigger cubic

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review found no issues

No high-confidence issues detected in this change.

@Kludex
Kludex merged commit 4b5fe5a into main Oct 11, 2026
36 checks passed
@Kludex
Kludex deleted the codex/remove-unused-chatbot-stdio-context branch October 11, 2026 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Simple chatbot: unused Server.stdio_context attribute obscures transport ownership

1 participant