Add custom content support to ToolError for isError responses by hanzili · Pull Request #1824 · modelcontextprotocol/python-sdk · GitHub
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 35 additions & 1 deletion src/mcp/server/fastmcp/exceptions.py
3 changes: 3 additions & 0 deletions src/mcp/server/fastmcp/tools/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,9 @@ async def run(
# Re-raise UrlElicitationRequiredError so it can be properly handled
# as an MCP error response with code -32042
raise
except ToolError:
# Re-raise ToolError as-is to preserve custom content
raise
except Exception as e:
raise ToolError(f"Error executing tool {self.name}: {e}") from e

Expand Down
11 changes: 11 additions & 0 deletions src/mcp/server/lowlevel/server.py
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ async def main():

import mcp.types as types
from mcp.server.experimental.request_context import Experimental
from mcp.server.fastmcp.exceptions import ToolError
from mcp.server.lowlevel.experimental import ExperimentalHandlers
from mcp.server.lowlevel.func_inspection import create_call_wrapper
from mcp.server.lowlevel.helper_types import ReadResourceContents
Expand Down Expand Up @@ -573,6 +574,16 @@ async def handler(req: types.CallToolRequest):
# Re-raise UrlElicitationRequiredError so it can be properly handled
# by _handle_request, which converts it to an error response with code -32042
raise
except ToolError as e:
# ToolError can have custom content for the error response
if e.content is not None:
return types.ServerResult(
types.CallToolResult(
content=e.content,
isError=True,
)
)
return self._make_error_result(str(e))
except Exception as e:
return self._make_error_result(str(e))

Expand Down
220 changes: 220 additions & 0 deletions tests/issues/test_348_tool_error_content.py