{{ message }}
fall through if PRM endpoint is not implemented#1562
Closed
dogacancolak wants to merge 3 commits into
Closed
Conversation
maxisbey
added
needs more eyes
auth
maxisbey
requested changes
Nov 4, 2025
maxisbey
left a comment
maxisbey
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the PR! Could you please add a unit test for this which would fail before the fix and pass with your changes
Contributor
Author
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
As raised in #1495, one of the changes in #1324 included raising an error if PRM endpoint request failed. This caused backwards compatibility issues with MCP servers that haven't yet added support for PRM
How Has This Been Tested?
Breaking Changes
Types of changes
Checklist
Additional context