{{ message }}
Repository navigation
feat: implement size-limited LRU cache for JSON Schema validation - #845
Open
joaquinescalante23 wants to merge 1 commit into
Open
joaquinescalante23 wants to merge 1 commit into
joaquinescalante23 wants to merge 1 commit into
Conversation
Author
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

I noticed that the current
DefaultJsonSchemaValidatorimplementations (Jackson 2 and 3) were using an unboundedConcurrentHashMapfor schema caching, which could lead to memory leaks in long-running processes if exposed to a large number of dynamic schemas.This PR addresses the
TODOin both modules by:LinkedHashMap.generateCacheKeylogic to use a stable JSON representation of the schema instead of the defaulthashCode(), preventing potential collisions and ensuring cache hits are reliable regardless of map order.These changes significantly improve the resilience and resource management of the SDK when validating complex MCP tool outputs.