{{ message }}
Repository navigation
Add request-scoped notifier factory to modern server - #1210
Draft
tarun-agarwal1044 wants to merge 1 commit into
Draft
tarun-agarwal1044 wants to merge 1 commit into
tarun-agarwal1044 wants to merge 1 commit into
Conversation
Allow applications to wrap the default async notifier using the request context. Preserve permissive defaults and apply customization to sync and async streaming handlers. Report factory failures through the existing streaming error path.
tarun-agarwal1044
force-pushed
the
feat/1197-notifier-factory
branch
from
October 21, 2026 12:41
d3e5aed to
d01c6dd
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Motivation and context
Fixes #1197.
Applications need a place to enforce their own outgoing-notification policy, such as filtering request-scoped log messages or extension notifications. The default behavior should remain permissive.
This is a draft for feedback on the public API shape before marking it ready for review.
Changes
McpServer.Builder.notifierFactory(BiFunction<McpRequestContext, McpAsyncNotifier, McpAsyncNotifier>).API choice for discussion
The factory receives the default notifier rather than a Reactor sink. This supports policy decorators without exposing sink internals or adding another public interface. The default factory simply returns the supplied notifier.
Validation
117 selected core and transport tests passed, with no failures or skips:
Formatting is validated by the Maven build. The full repository and conformance suites were not run.
AI-assisted implementation using GitHub Copilot.