{{ message }}
Add support for URL mode elicitation#1021
Merged
Merged
Conversation
halter73
force-pushed
the
halter73/750
branch
from
0debdd5 to
8ee8b5b
Compare
halter73
commented
Nov 24, 2025
PederHP
reviewed
Nov 24, 2025
Member
halter73
force-pushed
the
halter73/750
branch
from
31c3125 to
66a0c7e
Compare
Contributor
Author
stephentoub
reviewed
Nov 25, 2025
stephentoub
reviewed
Nov 25, 2025
stephentoub
reviewed
Nov 25, 2025
stephentoub
reviewed
Nov 25, 2025
stephentoub
approved these changes
Nov 25, 2025
This was referenced Nov 25, 2025
# Conflicts: # docs/concepts/elicitation/elicitation.md # src/ModelContextProtocol.Core/McpSessionHandler.cs # src/ModelContextProtocol.Core/Protocol/ElicitRequestParams.cs # src/ModelContextProtocol.Core/Protocol/ElicitationCapability.cs # src/ModelContextProtocol.Core/Protocol/NotificationMethods.cs # tests/ModelContextProtocol.Tests/Protocol/ElicitationDefaultValuesTests.cs # tests/ModelContextProtocol.Tests/Server/McpServerExtensionsTests.cs
…emoteProtocolException method
The client Streamable HTTP transport does not wait on the SSE GET request to complete ConnectAsync, so there's a test-only race that the server might shutdown before HttpClient even creates a connection for the parallel GET request that results in a IOException with the message "The KestrelInMemoryTransport has been shut down." Regardless, as with the DELETE request, it's not helpful to throw from DisposeAsync just because there were problems with the optional GET request
halter73
added a commit
that referenced
this pull request
Dec 5, 2025
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support URL mode elicitation requests defined by SEP-1036 which is for out-of-band server-to-client elicitations that may involve sensitive data the MCP server doesn't want to give to the MCP client or host.
Fixes #750