{{ message }}
Add allowClientError to Scenario interface for expected client failures#123
Merged
pcarleton merged 2 commits intoJan 26, 2026
Merged
Conversation
pcarleton
requested changes
Jan 26, 2026
pcarleton
left a comment
pcarleton
left a comment
Member
There was a problem hiding this comment.
Love it, thank you! one minor nit.
for a follow-up: I'm thinking clientOutput should actually be a mandatory argument to printing the results. so we don't have to do that existence check. If we don't have an exitCode we should likely consider it a failure, but happy to tackle that separately
Co-authored-by: Paul Carleton <paulcarletonjr@gmail.com>
pcarleton
approved these changes
Jan 26, 2026
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Prior to this change, client conformance tests could fail in expected error cases because the client exited with a non-zero exit code. This behavior should be allowed and considered as passing for expected error tests.
How Has This Been Tested?
Ran the tests locally.
Breaking Changes
No previously passing test should fail as a result of this change.
Types of changes
Checklist
Additional context