feat: mod/client referrals#152
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
davidfurlong
left a comment
davidfurlong
left a comment
There was a problem hiding this comment.
almost there! We should probably also redeploy the example with the new env variable as well
| input={getText()} | ||
| embeds={getEmbeds()} | ||
| api={API_URL} | ||
| clientReferralAddress={CLIENT_REFERRAL_ADDRESS} |
There was a problem hiding this comment.
needs to be changed in the docs as well
| fid?: string; | ||
| }; | ||
| }; | ||
| clientReferralAddress?: `0x${string}`; |
There was a problem hiding this comment.
should have a comment above describing it further; on which chain? EOA required?
I think we should also call it appEthRewardsAddress or something instead
There was a problem hiding this comment.
Will add a comment. I'm not too attached to the name, but I do prefer referring to the party implementing Mod as the client since app could be ambiguous
There was a problem hiding this comment.
we should probably check that this custodyAddress is valid in other ways, such as the length or characters. I have no idea what happens if you overflow the end of txData here but I don't want to find out
2 participants
Change Summary
ModManifest'scustodyAddressfieldTodo: Indexer and claiming site
Merge Checklist