{{ message }}
Repository navigation
api, client: don't use a pointer-slice for plugins - #51440
Merged
Merged
Conversation
thaJeztah
added
status/2-code-review
impact/changelog
kind/refactor
Member
Author
The backend and router don't use a pointer-slice (the server actually doesn't use the `plugin.ListResponse` type and a straight slice); https://github.com/moby/moby/blob/778e5bfad3098bcc1b1457634e14c1c204ebf851/daemon/server/router/plugin/backend.go#L20 https://github.com/moby/moby/blob/6baf274fa3e90731ac653967cb0cea38e82b5e36/daemon/server/router/plugin/plugin_routes.go#L276-L280 Align the type in the API to match, and update the type defined in the client accordingly. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
plugins_no_pointer
branch
from
November 7, 2025 20:02
6ca55f2 to
15a048c
Compare
thaJeztah
marked this pull request as ready for review
November 7, 2025 21:17
vvoland
approved these changes
Nov 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The backend and router don't use a pointer-slice (the server actually doesn't use the
plugin.ListResponsetype and a straight slice);moby/daemon/server/router/plugin/backend.go
Line 20 in 778e5bf
moby/daemon/server/router/plugin/plugin_routes.go
Lines 276 to 280 in 6baf274
Align the type in the API to match, and update the type defined in the client accordingly.
- What I did
- How I did it
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)