{{ message }}
Repository navigation
client/container_exec: Wrap options and result - #51262
Merged
Merged
Conversation
vvoland
force-pushed
the
client-containerexec-opts
branch
2 times, most recently
from
October 22, 2025 11:12
c0b1502 to
cecdf29
Compare
vvoland
force-pushed
the
client-containerexec-opts
branch
from
October 22, 2025 11:46
cecdf29 to
c54ece9
Compare
thaJeztah
reviewed
Oct 22, 2025
Comment on lines
-24
to
25
Member
There was a problem hiding this comment.
Was on the fence on renaming ExecCreateOptions to ContainerExecCreateOptions - considering if we should go the reverse, and make Exec its own thing (not ContainerXXX); WDYT?
Contributor
Author
There was a problem hiding this comment.
Yeah I think it could work too.. But whatever we choose we should match the prefix of the option/result struct with the operation name.
Member
There was a problem hiding this comment.
Yeah, perhaps ExecCreate instead of ContainerExecCreate would work; it's shorter as well, and matches that we have the ExecClient interface defined .. which was slightly to split things a bit.
Let me know what you think
vvoland
force-pushed
the
client-containerexec-opts
branch
2 times, most recently
from
October 22, 2025 12:27
c9f6be6 to
0e78a5c
Compare
vvoland
added
impact/changelog
impact/go-sdk
Member
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
thaJeztah
force-pushed
the
client-containerexec-opts
branch
from
October 22, 2025 20:49
0e78a5c to
94ab385
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.