profiles/apparmor, seccomp: migrate to separate module by thaJeztah · Pull Request #50481 · moby/moby · GitHub
Skip to content

profiles/apparmor, seccomp: migrate to separate module - #50481

Merged
austinvazquez merged 1 commit into
moby:masterfrom
thaJeztah:migrate_profiles
Jul 22, 2025
Merged

profiles/apparmor, seccomp: migrate to separate module#50481
austinvazquez merged 1 commit into
moby:masterfrom
thaJeztah:migrate_profiles

Conversation

@thaJeztah

@thaJeztah thaJeztah commented Jul 22, 2025

Copy link
Copy Markdown
Member

- Human readable description for the release notes

Go SDK: deprecate profiles package which got migrated to github.com/moby/profiles

- A picture of a cute animal (not mandatory but encouraged)

@thaJeztah thaJeztah added this to the 29.0.0 milestone Jul 22, 2025
thaJeztah
thaJeztah commented Jul 22, 2025
View reviewed changes
Comment thread vendor.mod Outdated
Comment on lines +10 to +13

@thaJeztah thaJeztah Jul 22, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go really doesn't like submodules; it happily took github.com/moby/profiles/apparmor, but then didn't know what to do with github.com/moby/profiles/seccomp (module found but doesn't have package).

Possibly it took the root of the repo, then used apparmor as a package not a module

@thaJeztah thaJeztah added area/go-sdk impact/go-sdk Noteworthy (compatibility changes) in the Go SDK impact/deprecation labels Jul 22, 2025
@thaJeztah
thaJeztah force-pushed the migrate_profiles branch 2 times, most recently from a81b84c to 0d68120 Compare July 22, 2025 16:34
@thaJeztah

thaJeztah commented Jul 22, 2025

Copy link
Copy Markdown
Member Author

Ah, looks like we have a CLI integration test that uses the JSON file that was in it, but now moved to the vendor directory;

=== Failed
=== FAIL: amd64.integration-cli TestDockerCLIRunSuite/TestRunSeccompWithDefaultProfile (0.05s)
    docker_cli_run_unix_test.go:1324: assertion failed: 
        --- ←
        +++ →
        @@ -1,2 +1 @@
        -/usr/local/cli-integration/docker: opening seccomp profile (../profiles/seccomp/default.json) failed: open ../profiles/seccomp/default.json: no such file or directory.
        -See '/usr/local/cli-integration/docker run --help'.
        +unshare: unshare failed: Operation not permitted
        
    --- FAIL: TestDockerCLIRunSuite/TestRunSeccompWithDefaultProfile (0.05s)

@thaJeztah
profiles/apparmor, seccomp: migrate to separate module
a600da9 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
thaJeztah marked this pull request as ready for review July 22, 2025 18:05
austinvazquez
austinvazquez approved these changes Jul 22, 2025
View reviewed changes

@austinvazquez austinvazquez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woot! LGTM.

@austinvazquez

austinvazquez commented Jul 22, 2025

Copy link
Copy Markdown
Contributor

@austinvazquez
austinvazquez merged commit 38a612c into moby:master Jul 22, 2025
@thaJeztah
thaJeztah deleted the migrate_profiles branch July 22, 2025 18:57
@thaJeztah thaJeztah mentioned this pull request Jul 25, 2025
Merged
@dmcgowan dmcgowan mentioned this pull request Aug 6, 2025
Closed
@dmcgowan dmcgowan mentioned this pull request Sep 5, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmcgowan dmcgowan dmcgowan approved these changes
@austinvazquez austinvazquez austinvazquez approved these changes

Assignees

No one assigned

Labels

area/go-sdk area/security/apparmor area/security/seccomp go-modules impact/deprecation impact/go-sdk Noteworthy (compatibility changes) in the Go SDK status/2-code-review

Projects

None yet

Milestone

29.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@thaJeztah @austinvazquez @dmcgowan @vvoland