Remove client buildkit dep by dmcgowan · Pull Request #50318 · moby/moby · GitHub
Skip to content

Remove client buildkit dep - #50318

Merged
vvoland merged 1 commit into
moby:masterfrom
dmcgowan:client-remove-buildkit-dep
Jul 9, 2025
Merged

vvoland merged 1 commit into
moby:masterfrom
dmcgowan:client-remove-buildkit-dep

Conversation

@dmcgowan

@dmcgowan dmcgowan commented Jul 2, 2025 •

Copy link
Copy Markdown
Member

This package does not need to be in the client package. It is not used anywhere and no one imports it (https://pkg.go.dev/github.com/docker/docker@v28.3.0+incompatible/client/buildkit) and it creates a buildkit dependency from the future client module.

Go-SDK: Remove `buildkit.ClientOpts`

@thaJeztah

Copy link
Copy Markdown
Member

Remove unused package from client which brings in buildkit dep

Signed-off-by: Derek McGowan <derek@mcg.dev>
@dmcgowan
dmcgowan force-pushed the client-remove-buildkit-dep branch from 843bb97 to aae26b8 Compare July 2, 2025 23:08
@dmcgowan

dmcgowan commented Jul 2, 2025

Copy link
Copy Markdown
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/go-sdk impact/changelog impact/deprecation impact/go-sdk Noteworthy (compatibility changes) in the Go SDK kind/refactor PR's that refactor, or clean-up code

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants