{{ message }}
Repository navigation
libcontainerd/local: remove unused code and arguments - #49551
Merged
Merged
Conversation
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Also remove an intermediate var, and remove a "WithError" in favor of adding the error field to the "WithFields". Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
The "local" client does not use containerd, but implements the same interface, many args are not used though, so remove these to make it more clear what's actually in use. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
The "local" client does not use containerd, but implements the same interface, many args are not used though, so remove these to make it more clear what's actually in use. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
added
platform/windows
status/2-code-review
kind/refactor
austinvazquez
approved these changes
Feb 27, 2025
vvoland
approved these changes
Feb 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libcontainerd/local: client.extractResourcesFromSpec: use early return
libcontainerd/local: client.NewContainer: use early return
Also remove an intermediate var, and remove a "WithError" in favor of
adding the error field to the "WithFields".
libcontainerd/local: client.createWindows: remove unused runtimeOptions
The "local" client does not use containerd, but implements the same interface,
many args are not used though, so remove these to make it more clear what's
actually in use.
libcontainerd/local: NewClient: remove unused cli, stateDir, ns args
The "local" client does not use containerd, but implements the same interface,
many args are not used though, so remove these to make it more clear what's
actually in use.
libcontainerd/local: remove arg-names for stubs
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)