{{ message }}
Repository navigation
pkg/jsonmessage: stop printing deprecated progressDetail, errorDetail, remove DisplayJSONMessagesToStream and Stream interface - #49264
Merged
Conversation
thaJeztah
added
area/api
thaJeztah
force-pushed
the
jsonmessage_remove_deprecated
branch
from
January 13, 2025 13:20
d4db89a to
73b0797
Compare
Member
Author
thaJeztah
force-pushed
the
jsonmessage_remove_deprecated
branch
from
July 14, 2025 16:23
73b0797 to
58048d0
Compare
thaJeztah
force-pushed
the
jsonmessage_remove_deprecated
branch
2 times, most recently
from
July 23, 2025 12:32
69eb214 to
8d8ecd8
Compare
thaJeztah
force-pushed
the
jsonmessage_remove_deprecated
branch
2 times, most recently
from
July 30, 2025 11:24
f8967b1 to
dac3a63
Compare
thaJeztah
changed the title
thaJeztah
force-pushed
the
jsonmessage_remove_deprecated
branch
2 times, most recently
from
July 30, 2025 12:35
1a4ae99 to
45d370c
Compare
The API still returns it for backward-compatibility (but probably shouldn't), but we should no longer print it. This removes the use of these fields for printing, but keeps them for streamformatter to use. - ErrorMessage was deprecated in 3043c26 - ProgressMessage was deprecated in 597e0e6 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
It was an adaptor around DisplayJSONMessagesStream for CLI-specific primitives that was used in the CLI, but can be implemented by users of this package. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
It was an interface to match CLI-specific primitives and is no longer used. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
jsonmessage_remove_deprecated
branch
from
July 30, 2025 21:23
45d370c to
2b4506b
Compare
thaJeztah
changed the title
thaJeztah
force-pushed
the
jsonmessage_remove_deprecated
branch
from
July 30, 2025 21:24
2b4506b to
f3ba0b2
Compare
Member
Author
thaJeztah
marked this pull request as ready for review
July 30, 2025 21:39
dmcgowan
approved these changes
Jul 30, 2025
This was referenced Aug 4, 2025
This was referenced Sep 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
depends on these fixes to be released in docker-py;
pkg/jsonmessage: stop printing deprecated progressDetail, errorDetail
The API still returns it for backward-compatibility (but probably
shouldn't), but we should no longer print it. This removes the
use of these fields for printing, but keeps them for streamformatter
to use.
client/pkg/jsonmessage: remove DisplayJSONMessagesToStream
It was an adaptor around DisplayJSONMessagesStream for CLI-specific
primitives that was used in the CLI, but can be implemented by users
of this package.
client/pkg/jsonmessage: remove Stream interface
It was an interface to match CLI-specific primitives and is no
longer used.
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)