{{ message }}
Repository navigation
Conversation
cf3901646
changed the title
Contributor
github-actions
Bot
added
Smoke tests: Pass
Smoke tests: Unknown
and removed
Smoke tests: Unknown
Smoke tests: Pass
labels
Contributor
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Fixed a bare \except:\ clause in \mlrun/datastore/model_provider/openai_provider.py\ that was catching \BaseException\ implicitly. This anti-pattern is flagged by Ruff rule E722 and can cause subtle issues. The change replaces \except:\ with \except BaseException:\ to preserve the exact same behavior (including catching \�syncio.CancelledError) while making the intent clear and satisfying linting requirements.
Motivation & Context
Closes #9860
The bare \except:\ clause was catching \BaseException\ implicitly, which includes \KeyboardInterrupt, \SystemExit, and \�syncio.CancelledError. While the code re-raises the exception, using a bare \except:\ is a Python anti-pattern and makes the intent unclear. The fix ensures that the code continues to cancel all sibling tasks when any task fails, including cancellation signals, while being explicit about what is being caught.
Verification