{{ message }}
Bump min npm to 11.16.0 in setup-node action#23639
Merged
Merged
Conversation
Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
Contributor
github-actions
Bot
added
area/build
Member
Author
|
/review ✅ Review completed (claude-sonnet-4-6, 49.5s, 11 turns, 2396 tokens, $0.14) Result{
"type": "result",
"subtype": "success",
"is_error": false,
"api_error_status": null,
"duration_ms": 49477,
"duration_api_ms": 44993,
"ttft_ms": 2182,
"num_turns": 11,
"result": "The payload validated. Here's the review summary:\n\n**PR #23639 — Bump min npm to 11.16.0 in setup-node action**\n\n**Decision: APPROVE** — no findings.\n\nThe change is a one-line version bump (`^11.10.0` → `^11.16.0`) with a comment update that accurately explains the new motivation (allowScripts opt-in install-script policy) and links to the upstream npm PR for traceability. The `^` range is intentional and consistent with the prior approach. No behavioral change to install scripts in Phase 1 (advisory-only), so CI risk is low. Nothing to flag.",
"stop_reason": "end_turn",
"session_id": "5b51d0f2-5cdb-4baf-a2c9-2b6f770e1ade",
"total_cost_usd": 0.14359034999999998,
"usage": {
"input_tokens": 10,
"cache_creation_input_tokens": 15321,
"cache_read_input_tokens": 165962,
"output_tokens": 2386,
"server_tool_use": {
"web_search_requests": 0,
"web_fetch_requests": 0
},
"service_tier": "standard",
"cache_creation": {
"ephemeral_1h_input_tokens": 0,
"ephemeral_5m_input_tokens": 15321
},
"inference_geo": "",
"iterations": [
{
"input_tokens": 1,
"output_tokens": 152,
"cache_read_input_tokens": 28291,
"cache_creation_input_tokens": 147,
"cache_creation": {
"ephemeral_5m_input_tokens": 147,
"ephemeral_1h_input_tokens": 0
},
"type": "message"
}
],
"speed": "standard"
},
"modelUsage": {
"claude-haiku-4-5-20251001": {
"inputTokens": 448,
"outputTokens": 16,
"cacheReadInputTokens": 0,
"cacheCreationInputTokens": 0,
"webSearchRequests": 0,
"costUSD": 0.000528,
"contextWindow": 200000,
"maxOutputTokens": 32000
},
"claude-sonnet-4-6": {
"inputTokens": 10,
"outputTokens": 2386,
"cacheReadInputTokens": 165962,
"cacheCreationInputTokens": 15321,
"webSearchRequests": 0,
"costUSD": 0.14306235,
"contextWindow": 200000,
"maxOutputTokens": 32000
}
},
"permission_denials": [],
"terminal_reason": "completed",
"fast_mode_state": "off",
"uuid": "036dcc7d-f15d-44cc-9182-bfb7bf586a74"
} |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the repository’s composite Node setup action to install a newer minimum npm version for CI/build workflows.
Changes:
- Bumps the pinned npm minimum from
^11.10.0to^11.16.0. - Updates the inline comment to explain the
allowScriptspolicy motivation.
![mlflow-app[bot]](https://avatars.githubusercontent.com/in/1088522?s=60&v=4){kind=small}
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues/PRs
Relates to npm/cli#9360
What changes are proposed in this pull request?
Bump the minimum npm pinned by
.github/actions/setup-node/action.ymlfrom^11.10.0to^11.16.0.Why: npm 11.16.0 ships Phase 1 of the
allowScriptsopt-in install-script policy (npm/cli#9360). Phase 1 is advisory-only:npm installnow prints a block listing dependencies whose install scripts haven't been reviewed viaallowScriptsinpackage.json. No install behavior changes, but bumping the floor here lets us see those advisories in CI ahead of Phase 2, which will turn the advisory into an actual block.How is this PR tested?
Does this PR require documentation update?
Does this PR require updating the MLflow Skills repository?
Release Notes
Is this a user-facing change?
What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/build: Build and test infrastructure for MLflowHow should the PR be classified in the release notes? Choose one:
rn/none- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionIs this PR a critical bugfix or security fix that should go into the next patch release?
🤖 Generated with Claude Code