Fix breadcrumb display in readthedocs theme by oprypin · Pull Request #3383 · mkdocs/mkdocs · GitHub
Skip to content

Fix breadcrumb display in readthedocs theme#3383

Merged
oprypin merged 2 commits into
masterfrom
breadcrumbs
Sep 13, 2023
Merged

Fix breadcrumb display in readthedocs theme#3383
oprypin merged 2 commits into
masterfrom
breadcrumbs

Conversation

@oprypin

@oprypin oprypin commented Sep 10, 2023

Copy link
Copy Markdown
  • Fix broken styling of breadcrumbs in readthedocs theme

    Commit 3c3670d left it half way between the old and new style

    Fixes Something is wrong with readthedocs theme breadcrumbs #3382

  • Fix linkified breadcrumb items in readthedocs theme

    A doc can never have a link attribute so this branch never kicked in.
    Actually even now, this branch will still not kick in, only mkdocs-section-index makes this state possible.

Oleh Prypin added 2 commits September 11, 2023 00:03
Commit 3c3670d left it half way between the old and new style
A doc can never have a `link` attribute so this branch never kicked in.

Actually even now, this branch will still not kick in, only mkdocs-section-index makes this state possible.

@ultrabug ultrabug left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch o_O

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Something is wrong with readthedocs theme breadcrumbs

2 participants