{{ message }}
Repository navigation
Fix Set-Cookie attribute parsing for short Expires values - #8489
Merged
Merged
Conversation
lups2000
approved these changes
Oct 20, 2026
lups2000
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR :) LGTM!
Could you just solve the conflict with the changelog?
2 tasks done
lups2000
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Fixes #8488
In
cookies._read_set_cookie_pairs,Expireshandling assumed that any value withlen(rhs) <= 3was a weekday prefix followed by a comma, without checking whether the delimiter was actually a comma. For headers likeSet-Cookie: session=abc; Expires=0; Secure, the parser skipped past the semicolon and consumedSecureintoExpires="0, Secure", dropping theSecureattribute. In addition, RFC 850 dates with full weekday names (Wednesday, ...) failed the length check and were prematurely split into phantom cookies.Approach chosen:
_WEEKDAYScontaining RFC 1123 and RFC 850 weekday names.off < len(s) and s[off] == ",") AND the parsed value corresponds to a weekday name (rhs.strip().lower() in _WEEKDAYS).Expires=0followed bySecure; HttpOnlyexpires=0Verification:
uv run pytest test/mitmproxy/net/http/test_cookies.py(11/11 tests pass).uv run pytest test/mitmproxy/net/http/(113/113 tests pass).uv run ruff checkanduv run ruff format --check(clean).Checklist