{{ message }}
Repository navigation
Fix console commands view on urwid 4.0, prepare for urwid 5.0 - #8481
Open
penguinolog wants to merge 2 commits into
Open
penguinolog wants to merge 2 commits into
penguinolog wants to merge 2 commits into
Conversation
The console's commands view read Pile.focus_item, which urwid 4.0 removed, so any key press in that view raised AttributeError on urwid 4.0.x. The console also used urwid APIs that urwid 5.0 removes or deprecates. - Pile.widget_list and Pile.focus_item -> Pile.contents, focus and focus_position in the commands, options and key bindings views. - ListBox.get_focus() -> ListBox.focus; the position it returned was unused. - Pile.get_item_size() -> Pile.get_rows_sizes(); deprecated, removal in urwid 7.0. - urwid.raw_display -> urwid.display.raw; deprecated, removal in urwid 7.0. - Add a test that selects a command in the commands view. All replacements are available in urwid 2.6.14, mitmproxy's minimum.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The console's commands view read Pile.focus_item, which urwid 4.0 removed, so any key press in that view raised AttributeError on urwid 4.0.x.
The console also used urwid APIs that urwid 5.0 removes or deprecates.
All replacements are available in urwid 2.6.14, mitmproxy's minimum.
Checklist