{{ message }}
Repository navigation
docs: fix relative link to version.py in the release README - #8441
Open
1816586742-stack wants to merge 1 commit into
Open
1816586742-stack wants to merge 1 commit into
1816586742-stack wants to merge 1 commit into
Conversation
The link target was written as mitmproxy/version.py, which from release/ resolves to release/mitmproxy/version.py and therefore 404s. Point it at the file at the repository root, which is where it actually lives.
Member
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix the relative link to
mitmproxy/version.pyin the release README.Why
The last step of the release checklist links to the version file like this:
Relative to
release/README.md, that target resolves torelease/mitmproxy/version.py, which does not exist — the link 404s. The file is at the repository root:One character class of fix — the target now starts with
../and resolves to the file that actually exists.Verification
mitmproxy/version.pyexists at the repository roothttps://URL, so nothing else in it is affectedrelease/*.md: this was the only broken oneI kept the visible link text unchanged so the diff stays to one line; if you would rather simplify the text to
version.pyat the same time, say the word and I will fold it in.