Device selection fix by quantum-x · Pull Request #49 · mitmproxy/android-unpinner · GitHub
Skip to content

Device selection fix - #49

Open
quantum-x wants to merge 2 commits into
mitmproxy:mainfrom
quantum-x:main
Open

quantum-x wants to merge 2 commits into
mitmproxy:mainfrom
quantum-x:main

Conversation

@quantum-x

Copy link
Copy Markdown

Fixing a slight bug in @Davis-3450's PR - Device selection (-s) must be directly after the ADB command.

Device selection (-s) must be directly after the ADB command.
@quantum-x
quantum-x marked this pull request as draft August 26, 2025 15:29
Corrected logic error relating to commands without a device.
@quantum-x
quantum-x marked this pull request as ready for review August 26, 2025 15:32
@Davis-3450

Copy link
Copy Markdown
Contributor

@quantum-x

Copy link
Copy Markdown
Author

@Davis-3450 Didn't want to be someone that complained without fixing.
Haven't written python in a while, so my solution definitely might not be pythonesque!

However it works, and got me past my problem. Would be more than happy for you to adjust as per PEP 8 - that's why I @'d you!

Thanks very much

@Davis-3450

Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants