{{ message }}
This repository was archived by the owner on Jul 22, 2024. It is now read-only.
Fix discrepancy between BasicUi and MockUi#71
Merged
Conversation
Owner
alisdair
added a commit
to hashicorp/terraform
that referenced
this pull request
Sep 10, 2020
Update tests to match the fix in mitchellh/cli#71, which aligns MockUi with BasicUi and allows newlines in user input. We are not using the new ErrorWriter, added in mitchellh/cli#81, as it does not appear to interact correctly with panicwrap. All error output from CLI parsing will continue to appear on stdout, not stderr.
swalkinshaw
added a commit
to roots/trellis-cli
that referenced
this pull request
Oct 30, 2020
This requires a newline after mitchellh/cli#71
swalkinshaw
added a commit
to roots/trellis-cli
that referenced
this pull request
Oct 30, 2020
This requires a newline after mitchellh/cli#71
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed the
Askmethod onBasicUitype usesbufio.Reader.ReadString()whereas theAskmethod onMockUiusesfmt.Fscanlnfor reading fromReaderinput. This causes two problems:When using
BasicUi, one can enter a string with spaces. However, in tests when usingMockUi, reading a string with spaces only returns the first word.When using
BasicUi, one can pressEnterkey and get a empty string back without any error, while usingMockUiin tests returns anunexpected newlineerror.This discrepancy between the actual implementation of
Askand the mocked implementation ofAskmakes testing of the two cases mentioned above very hard.This PR addresses this issue and make the actual and mocked implementation working the same way.