Assert float input type for Scalar class by janhenrikbern · Pull Request #3 · minitorch/Module-1 · GitHub
Skip to content

Assert float input type for Scalar class#3

Merged
srush merged 3 commits into
minitorch:masterfrom
janhenrikbern:master
Sep 21, 2020
Merged

Assert float input type for Scalar class#3
srush merged 3 commits into
minitorch:masterfrom
janhenrikbern:master

Conversation

@janhenrikbern

Copy link
Copy Markdown
Contributor

This PR resolves the below type of downstream errors due to type mismatch.
Screen Shot 2020-09-18 at 3 31 02 PM

New behavior:
Screen Shot 2020-09-18 at 7 23 31 PM

Please refer to the Piazza question to read the issue thread.

@srush

srush commented Sep 20, 2020

Copy link
Copy Markdown
Contributor

@janhenrikbern

Copy link
Copy Markdown
Contributor Author

@srush srush merged commit 3f098d9 into minitorch:master Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants