Add patch for openflow to fix compile error when strlcpy is present on the system. by Greenscreen23 · Pull Request #1237 · mininet/mininet · GitHub
Skip to content

Add patch for openflow to fix compile error when strlcpy is present on the system.#1237

Open
Greenscreen23 wants to merge 1 commit into
mininet:masterfrom
Greenscreen23:master
Open

Add patch for openflow to fix compile error when strlcpy is present on the system.#1237
Greenscreen23 wants to merge 1 commit into
mininet:masterfrom
Greenscreen23:master

Conversation

@Greenscreen23

Copy link
Copy Markdown

This PR adds a patch to mininet to fix a build error in openflow which occurs when the host system already has strlcpy defined. This occurs on ubuntu 24.04 for example.

I reproduced the bug and tested the solution using this Dockerfile

FROM ubuntu:24.04

RUN apt update
RUN apt install -y sudo python3

COPY ./ /mininet
WORKDIR /mininet
RUN util/install.sh -f

I initially developed this patch for containernet, a fork of mininet: https://github.com/containernet/containernet/blob/master/util/openflow-patches/strlcpy.patch

I would also be fine with opening a PR on the openflow repo to fix the issue there. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant