{{ message }}
enables operation with 11-bit CAN messages#20
Open
DaveP987 wants to merge 3 commits into
Open
Conversation
Author
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #18
Introduces a new
strictparameter toBusthat specifies whether to operate strictly on J1939 messages or J1939 and 11-bit CAN messages.strict=Trueby default to maintain the current behavior.Handling of PDU vs non-PDU messages is broken out into separate methods.
So far, this seems to work fine for me as a simple drop-in replacement for
can.interface.Bususing existing 11-bit messaging.