Activate if workspace have Python-related files by bytemain · Pull Request #10856 · microsoft/vscode-python · GitHub
Skip to content

Activate if workspace have Python-related files#10856

Closed
bytemain wants to merge 6 commits into
microsoft:mainfrom
bytemain:master
Closed

Activate if workspace have Python-related files#10856
bytemain wants to merge 6 commits into
microsoft:mainfrom
bytemain:master

Conversation

@bytemain

@bytemain bytemain commented Mar 30, 2020

Copy link
Copy Markdown

close: #4765

For #

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • The wiki is updated with any design decisions/details.

@msftclas

msftclas commented Mar 30, 2020 •
edited
Loading

Copy link
Copy Markdown

@codecov-io

codecov-io commented Mar 30, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #10856 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10856      +/-   ##
==========================================
- Coverage   60.69%   60.66%   -0.03%     
==========================================
  Files         580      580              
  Lines       31512    31525      +13     
  Branches     4480     4479       -1     
==========================================
- Hits        19125    19124       -1     
- Misses      11419    11429      +10     
- Partials      968      972       +4
Impacted Files Coverage Δ
src/datascience-ui/react-common/arePathsSame.ts 75.00% <0.00%> (-12.50%) ⬇️
src/client/common/utils/platform.ts 64.70% <0.00%> (-11.77%) ⬇️
src/client/linters/pydocstyle.ts 86.66% <0.00%> (-2.23%) ⬇️
...interpreter/locators/services/KnownPathsService.ts 49.05% <0.00%> (-1.93%) ⬇️
src/client/datascience/debugLocationTracker.ts 76.56% <0.00%> (-1.57%) ⬇️
src/client/common/process/proc.ts 14.49% <0.00%> (-0.73%) ⬇️
src/client/common/featureDeprecationManager.ts 40.90% <0.00%> (-0.63%) ⬇️
...rpreter/locators/services/baseVirtualEnvService.ts 28.07% <0.00%> (-0.51%) ⬇️
src/client/linters/lintingEngine.ts 20.00% <0.00%> (-0.21%) ⬇️
.../client/testing/common/managers/baseTestManager.ts 45.13% <0.00%> (-0.18%) ⬇️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a4fab2...492fe83. Read the comment docs.

karrtikr
karrtikr reviewed Mar 30, 2020
View reviewed changes

@karrtikr karrtikr left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Can you please include all the files mentioned the issue, including comments. This for instance.

Also please thank yourself in the news entry. :)

rchiodo
rchiodo reviewed Mar 30, 2020
View reviewed changes
Comment thread package.json
@sonarqubecloud

sonarqubecloud Bot commented Mar 31, 2020

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@bytemain

bytemain commented Mar 31, 2020

Copy link
Copy Markdown
Author

There's so much stuff in Python community 😆

@karthiknadig

karthiknadig commented Mar 31, 2020

Copy link
Copy Markdown
Member

@lengthmin Thank you for the updates. We might want to wrap this in an experiment. See discussion on #4765.

@ericsnowcurrently ericsnowcurrently mentioned this pull request Apr 1, 2020
Merged
@BrandonLWhite BrandonLWhite mentioned this pull request Jun 3, 2020
Merged
10 tasks
@microsoft-github-updates microsoft-github-updates Bot changed the base branch from master to main September 3, 2020 21:07
brettcannon
brettcannon requested changes Nov 10, 2020
View reviewed changes

@brettcannon brettcannon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please only update for pyproject.toml.

@bytemain

bytemain commented Nov 11, 2020

Copy link
Copy Markdown
Author

@brettcannon it seem that this feature has already merged into main branch

should I close this pr?

@brettcannon

brettcannon commented Nov 11, 2020

Copy link
Copy Markdown
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rchiodo rchiodo rchiodo left review comments
@brettcannon brettcannon brettcannon requested changes
+1 more reviewer
@karrtikr karrtikr karrtikr left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@karrtikr karrtikr

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

If I have Python-related files in my workspace, automatically activate the extension

7 participants

@bytemain @msftclas @codecov-io @karthiknadig @brettcannon @karrtikr @rchiodo