{{ message }}
Repository navigation
feat: show sub-issues inline in the issue detail view - #9073
Open
Liora Milbaum (lmilbaum) wants to merge 1 commit into
Open
Liora Milbaum (lmilbaum) wants to merge 1 commit into
Liora Milbaum (lmilbaum) wants to merge 1 commit into
Conversation
- Fetch sub-issues via REST GET /repos/{owner}/{repo}/issues/{n}/sub_issues (per_page=100) and render them inline under the description when viewing a parent issue
- Add SubIssueReference type, convertRESTSubIssue() converter, and IssueModel.getSubIssues() -- errors (404/410 for older GHES, other) return [] and are logged without blocking pr.initialize
- Add SubIssues React component with open/closed state icons, title, #N / owner/repo#N label, and assignee avatars; cross-repo sub-issues show their owner/repo prefix
- Resolve sub-issue URLs to vscode:// in-editor links with per-item fallback to html_url on error so clicking a sub-issue opens it inside VS Code
- Add webview tests, IssueModel unit tests, and an IssueOverviewPanel wiring test
Closes microsoft#6596
Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Enterprise server links can resolve against GitHub.com, and child state and assignees lack accessible text.
2 open findings
What changed in this PR
Adds read-only sub-issues beneath issue descriptions in the extension, addressing the visualization portion of #6596.
Changes:
- Fetches and converts sub-issues, returning an empty list on errors.
- Displays child state, repository labels, assignees, and in-editor links.
- Adds model, panel wiring, and rendering tests.
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+421
to
+422
| const webviewUri = await toOpenIssueWebviewUri({ owner: subIssue.owner, repo: subIssue.repo, issueNumber: subIssue.number }); | ||
| return { ...subIssue, url: webviewUri.toString() }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GET /repos/{owner}/{repo}/issues/{n}/sub_issues(per_page=100) and render them inline under the description when viewing a parent issueSubIssueReferencetype,convertRESTSubIssue()converter, andIssueModel.getSubIssues()-- errors (404/410 for older GHES, other) return[]without blockingpr.initializeSubIssuesReact component with open/closed state icons, title,#N/owner/repo#Nlabel (cross-repo prefix), and assignee avatarshtml_urlon errorIssueModelunit tests, and anIssueOverviewPanelwiring testCloses #6596
How to test
Reviewer notes
🤖 Generated with Claude Code