{{ message }}
Repository navigation
Fix browser test execution and failure reporting - #9061
Open
Johanan (jidicula) wants to merge 2 commits into
Open
Johanan (jidicula) wants to merge 2 commits into
Johanan (jidicula) wants to merge 2 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 6dde41da-ec25-4370-b26c-b036d0a53b3c
Update browser fixtures and debug builds, repair hidden-workflow hygiene filtering, and remove the graduated agents window proposal. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 6dde41da-ec25-4370-b26c-b036d0a53b3c
Johanan (jidicula)
force-pushed
the
jidicula/graphql-browser-test-harness-20261009
branch
from
October 20, 2026 11:09
373ce40 to
31fc500
Compare
Johanan (jidicula)
marked this pull request as ready for review
October 20, 2026 11:35
Contributor
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Browser startup, failure propagation, and module-stub compatibility still need end-to-end validation.
No open issues 🎉
What changed in this PR
Repairs browser test startup and failure reporting while preserving the shipped extension’s module format. Browser CI jobs remain disabled.
Changes:
- Separates the browser test bundle and propagates discovery and execution failures.
- Adapts shared tests and mocks for browser compatibility.
- Updates debug setup, removes a graduated API proposal, and corrects workflow indentation filtering.
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The browser runner can stop discovering tests at a Node-only import and still report success. This fixes web-host startup and failure reporting, and makes the shared tests work with the existing browser dependencies.
The separate test bundle uses CommonJS, including Apollo's CommonJS entry, so the existing Sinon module stubs take effect. The shipped extension keeps its current module format. Browser execution remains disabled in
azure-pipeline.pr.ymlandazure-pipeline.nightly.yml; this change repairs the runner without enabling those jobs.Debug Web Testnow builds the web extension and test bundle before starting the test server. This also removes a graduated API proposal that broke type downloads and corrects indentation filtering for.githubYAML workflows.This is the prerequisite for the separate GraphQL User-Agent change.
Closes https://github.com/github/graphql-platform/issues/5142
Authored by Copilot, guided by Johanan (@jidicula).