check if the compiler path and debugger path exist. by elahehrashedi · Pull Request #9813 · microsoft/vscode-cpptools · GitHub
Skip to content

check if the compiler path and debugger path exist.#9813

Merged
elahehrashedi merged 11 commits into
mainfrom
elrashed/compilerPathExists
Sep 7, 2022
Merged

check if the compiler path and debugger path exist.#9813
elahehrashedi merged 11 commits into
mainfrom
elrashed/compilerPathExists

Conversation

@elahehrashedi

Copy link
Copy Markdown
Contributor

bug fix: #8836
Do not create a debug configuration for invalid compiler paths.

@elahehrashedi elahehrashedi requested review from a team and Colengms August 30, 2022 18:10
Comment thread Extension/src/Debugger/configurationProvider.ts Outdated
@elahehrashedi

Copy link
Copy Markdown
Contributor Author

@elahehrashedi

Copy link
Copy Markdown
Contributor Author

@sean-mcmanus does this message look good?
('debugger.path.not.exists', "Unable to find the {0} debugger in this path: {1}. The debug configuration for {2} is ignored.", \"${debuggerName}\", \"${debuggerPath}\", compilerName)

Comment thread Extension/src/Debugger/configurationProvider.ts Outdated
Comment thread Extension/src/Debugger/configurationProvider.ts Outdated
@sean-mcmanus

Copy link
Copy Markdown
Contributor

Comment thread Extension/src/Debugger/configurationProvider.ts Outdated
Comment thread Extension/src/Debugger/configurationProvider.ts Outdated
@elahehrashedi elahehrashedi force-pushed the elrashed/compilerPathExists branch from 2a22d8e to 6de5396 Compare September 6, 2022 21:50
Comment thread Extension/src/Debugger/configurationProvider.ts Outdated
@elahehrashedi elahehrashedi changed the title check if compiler path exists check if compiler path and the debugger path exist. Sep 6, 2022
@elahehrashedi elahehrashedi changed the title check if compiler path and the debugger path exist. check if the compiler path and debugger path exist. Sep 6, 2022
Comment thread Extension/src/Debugger/configurationProvider.ts Outdated
@elahehrashedi elahehrashedi merged commit 3526f50 into main Sep 7, 2022
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 23, 2022
@michelleangela michelleangela deleted the elrashed/compilerPathExists branch December 7, 2022 22:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Misleading error message when GDB is not installed

3 participants