Add inlay hint tests, fix setting update of autoDeclarationTypes.showOnLeft by michelleangela · Pull Request #9622 · microsoft/vscode-cpptools · GitHub
Skip to content

Add inlay hint tests, fix setting update of autoDeclarationTypes.showOnLeft#9622

Merged
michelleangela merged 2 commits into
mainfrom
mimatias/inlaytests
Jul 22, 2022
Merged

Add inlay hint tests, fix setting update of autoDeclarationTypes.showOnLeft#9622
michelleangela merged 2 commits into
mainfrom
mimatias/inlaytests

Conversation

@michelleangela

@michelleangela michelleangela commented Jul 21, 2022

Copy link
Copy Markdown
Contributor
  • Fix setting update of autoDeclarationTypes.showOnLeft.
  • Add inlay hint tests to E2E intelliSense tests. (The E2E intelliSense tests only run once a week internally)

@sean-mcmanus

sean-mcmanus commented Jul 22, 2022

Copy link
Copy Markdown
Contributor

@sean-mcmanus

sean-mcmanus commented Jul 22, 2022

Copy link
Copy Markdown
Contributor

Also -- why is the root test task showing as a pass when the inlay hint test fails? It's possible a change I made a while ago may have broken the test fail processing.

@sean-mcmanus

Copy link
Copy Markdown
Contributor

If you want to me to get the Windows E2E test to pass right away you or I could potentially add a fallback baseline for the failing tests until I can figure out what is causing the difference (not sure when that will be yet...hopefully next week).

@sean-mcmanus

sean-mcmanus commented Jul 22, 2022

Copy link
Copy Markdown
Contributor

If you want to me to get the Windows E2E test to pass right away you or I could potentially add a fallback baseline for the failing tests until I can figure out what is causing the difference (not sure when that will be yet...hopefully next week).

Oh, I believe the test failure is caused by a difference between the use of git clone and a non-git clone checkout leading to \r\n versus \n differences on Windows -- I think I can just add a fallback to handle both cases.

@michelleangela

Copy link
Copy Markdown
Contributor Author

@michelleangela michelleangela merged commit c357584 into main Jul 22, 2022
@michelleangela michelleangela deleted the mimatias/inlaytests branch July 22, 2022 22:22
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants