Extended remote support by xisui-MSFT · Pull Request #9569 · microsoft/vscode-cpptools · GitHub
Skip to content

Extended remote support#9569

Merged
sean-mcmanus merged 6 commits into
mainfrom
dev/xisui/extended_remote
Jul 19, 2022
Merged

Extended remote support#9569
sean-mcmanus merged 6 commits into
mainfrom
dev/xisui/extended_remote

Conversation

@xisui-MSFT

Copy link
Copy Markdown
Contributor

Extended remote support #9491 #9505 #8497 #9195
Also show process picker automatically when the process ID is not provided in launch.json

@xisui-MSFT

Copy link
Copy Markdown
Contributor Author

@sean-mcmanus

Copy link
Copy Markdown
Contributor

What release is this for?

@xisui-MSFT

Copy link
Copy Markdown
Contributor Author

What release is this for?

Extended remote was added to MIEngine several months ago: microsoft/MIEngine#1260, and this doesn't have any other dependencies. So ideally we would like to target the earliest release we can achieve.

@sean-mcmanus sean-mcmanus added this to the 1.11.3 milestone Jul 11, 2022
Comment thread Extension/src/Debugger/attachToProcess.ts Outdated
@Colengms

Copy link
Copy Markdown
Contributor

@xisui-MSFT We tend to use back-tick quoting in our settings descriptions (which render as markdown) to clarify for translators that they shouldn't translate specific words (such as true and false, which are the values required in JSON settings). You might consider making this clear in your strings. I see your existing use of true/false getting localized by some translators.

@xisui-MSFT

Copy link
Copy Markdown
Contributor Author

@xisui-MSFT We tend to use back-tick quoting in our settings descriptions (which render as markdown) to clarify for translators that they shouldn't translate specific words (such as true and false, which are the values required in JSON settings). You might consider making this clear in your strings. I see your existing use of true/false getting localized by some translators.

Can you give an example? I saw formats like {0}, so all relevant strings in this PR uses this format.

@sean-mcmanus

Copy link
Copy Markdown
Contributor

@xisui-MSFT We tend to use back-tick quoting in our settings descriptions (which render as markdown) to clarify for translators that they shouldn't translate specific words (such as true and false, which are the values required in JSON settings). You might consider making this clear in your strings. I see your existing use of true/false getting localized by some translators.

Can you give an example? I saw formats like {0}, so all relevant strings in this PR uses this format.

In https://github.com/microsoft/vscode-cpptools/blob/main/Extension/package.nls.json .

Comment thread Extension/src/Debugger/attachToProcess.ts Outdated
Comment thread Extension/src/Debugger/attachToProcess.ts Outdated
Comment thread Extension/src/Debugger/attachToProcess.ts Outdated
@sean-mcmanus

Copy link
Copy Markdown
Contributor

@sean-mcmanus sean-mcmanus merged commit f38f551 into main Jul 19, 2022
@sean-mcmanus sean-mcmanus deleted the dev/xisui/extended_remote branch July 19, 2022 20:49
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants