Fix issue with multiple didOpen by Colengms · Pull Request #6784 · microsoft/vscode-cpptools · GitHub
Skip to content

Fix issue with multiple didOpen#6784

Merged
Colengms merged 2 commits into
mainfrom
coleng/fix_issue_with_multiple_didOpen
Jan 15, 2021
Merged

Fix issue with multiple didOpen#6784
Colengms merged 2 commits into
mainfrom
coleng/fix_issue_with_multiple_didOpen

Conversation

@Colengms

@Colengms Colengms commented Jan 15, 2021

Copy link
Copy Markdown
Contributor

Added a check to didOpen in the protocolFilter to avoid handling didOpen for a file that is already being tracked, since it's possible that we may have received onDidChangeVisibleTextEditors and considered this a 'delayedOpen' prior to receiving a didOpen.

Fixed placement of telemetry tracking didOpen.

@sean-mcmanus

Copy link
Copy Markdown
Contributor

@Colengms Colengms merged commit 8e8482b into main Jan 15, 2021
@Colengms Colengms deleted the coleng/fix_issue_with_multiple_didOpen branch January 15, 2021 03:11
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants