Add logging/warnings when compile probing alters explicit user configuration details by Colengms · Pull Request #6180 · microsoft/vscode-cpptools · GitHub
Skip to content

Add logging/warnings when compile probing alters explicit user configuration details#6180

Merged
Colengms merged 14 commits into
masterfrom
coleng/compiler_probe_warnings
Sep 29, 2020
Merged

Add logging/warnings when compile probing alters explicit user configuration details#6180
Colengms merged 14 commits into
masterfrom
coleng/compiler_probe_warnings

Conversation

@Colengms

Copy link
Copy Markdown
Contributor

This is mostly plumbing. More relevant changes for this are in a PR for the native component.

  • Indicates in a configuration if values were explicitly provided by the user. (Otherwise, they are derived from defaults or other implicit behavior, which would not warrant disturbing the user with a warning).
  • Adds some strings for warning/logging (open to input on these).
  • Changed c18/gnu18 to c17/gnu17.
  • Removed prior fix for detecting compiler filename in environment path. This is now handled on the native side for all config types.

When combined with the corresponding native PR, addresses:

I will also have a PR for cpptools-api to make IntelliSenseMode optional from custom config providers, as we can now fully auto-detect it (and don't need to require all custom config providers to replicate that behavior).

@michelleangela

Copy link
Copy Markdown
Contributor

Comment thread Extension/src/LanguageServer/client.ts Outdated
Comment thread Extension/src/nativeStrings.json Outdated
@Colengms Colengms merged commit 9c835e5 into master Sep 29, 2020
@Colengms Colengms deleted the coleng/compiler_probe_warnings branch September 29, 2020 00:26
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants