{{ message }}
Fix issue in which source file selection for header TU's does not occur when reconfiguring custom config provider#4671
Merged
Conversation
added 4 commits
November 25, 2019 14:10
…into coleng/provder_reconfigure_headers
sean-mcmanus
approved these changes
Nov 27, 2019
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also fixes an issue in which settings are not refreshed after a configuration provider has changed.
Also updated provideCustomConfiguration to use this.configurationProvider instead of looking it up again based on the setting..
queueTaskWithTimeout was removed to avoid an error, as it's no longer called.
This (and a corresponding PR against the native processes) addresses #4649 . They should also address #3985