Fixes #64739 by joaomoreno · Pull Request #64803 · microsoft/vscode · GitHub
Skip to content

Fixes #64739#64803

Merged
joaomoreno merged 1 commit into
release/1.30from
joao/release/1.30/fix-64739
Dec 11, 2018
Merged

Fixes #64739#64803
joaomoreno merged 1 commit into
release/1.30from
joao/release/1.30/fix-64739

Conversation

@joaomoreno

Copy link
Copy Markdown
Member

This bug puts the darwin update service in a constant state of Checking for updates.... It happened because the symbol context is in our global scope due to the Mocha typings, so TypeScript failed to catch that use of context and it missing from the variable scope. @mjbvz Any way we can tweak that?

image

@joaomoreno joaomoreno added this to the November 2018 milestone Dec 11, 2018
@joaomoreno joaomoreno self-assigned this Dec 11, 2018
@joaomoreno joaomoreno requested a review from bpasero December 11, 2018 14:11
@joaomoreno joaomoreno merged commit c6e592b into release/1.30 Dec 11, 2018
@joaomoreno joaomoreno deleted the joao/release/1.30/fix-64739 branch December 11, 2018 14:17
@mjbvz

mjbvz commented Dec 12, 2018

Copy link
Copy Markdown
Contributor

@joaomoreno

Copy link
Copy Markdown
Member Author

@github-actions github-actions Bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants