{{ message }}
Repository navigation
chat: add reverse sticky scroll for persistent progress - #343159
Draft
Justin Chen (justschen) wants to merge 3 commits into
Draft
Justin Chen (justschen) wants to merge 3 commits into
Justin Chen (justschen) wants to merge 3 commits into
Conversation
Retain the active response row and clamp its live progress above the input or session pills without copying or reparenting it. Preserve document order, focus and animations across refreshes, and update geometry before paint to avoid resize and scroll jitter. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Measure the footer in document flow by removing its sticky transform as well as fractional alignment. Keep the shared-spacing assertion intact when progress is pinned above the input. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
3 open issues
What changed in this PR
Adds “reverse” bottom-sticky behavior so the live persistent-progress indicator stays visible above the input/session pills when users scroll back during an active chat response, without cloning or reparenting the DOM.
Changes:
- Introduces bottom-sticky scroll support in base list/tree (row retention + bottom edge clamping) and wires it into chat’s list for persistent progress.
- Updates chat widget padding boundaries to separate input/pills insets from decorative pet scroll padding; adds CSS/background treatment and scroll-down button offsetting.
- Adds fixtures and expands regression coverage across chat widget, list/tree, and accessibility help text.
Review effort: Lite
Reuse the refresh-time response target during scrolling rather than rebuilding transcript items for every scroll event. Document the list retention contract and provide a zero-offset CSS fallback. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Keeps the existing persistent-progress indicator visible when scrolling back through a running chat. The original element moves with the transcript until it reaches the bottom edge, then stays directly above the session pills, or above the input when no pills are present. Scrolling back restores its normal position.
Changes and implications
Behavior verification
With persistent progress enabled, start a response, scroll its progress toward the input, continue into earlier turns, then return to the response. Repeat with and without session pills and with an expanded terminal. There should be one live progress indicator, no change in terminal width, and no movement of the indicator once clamped.
npm run gulp compile-client— passed, including client type checking.The following regression selection passed: 1,253 tests, 6 pending.