{{ message }}
Repository navigation
Use harness model catalogues in agent files - #343060
Draft
Martin Aeschlimann (aeschli) wants to merge 7 commits into
Draft
Martin Aeschlimann (aeschli) wants to merge 7 commits into
Martin Aeschlimann (aeschli) wants to merge 7 commits into
Conversation
Martin Aeschlimann (aeschli)
added this pull request to stack #342888
October 20, 2026 22:19
Complete, highlight, hover, and validate Copilot body placeholders while suppressing unsupported Local file and tool reference syntax. Refs #342854 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Keep placeholder suggestions visible through Monaco filtering and replace existing identifier and closing-brace suffixes without duplication. Refs #342854 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Martin Aeschlimann (aeschli)
force-pushed
the
aeschli/agent-file-copilot-models
branch
from
October 20, 2026 22:24
33a169f to
cd0f5da
Compare
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Catalogue readiness, identifier handling, and cross-harness capability merging can produce incorrect editing feedback.
4 open issues
What changed in this PR
Adds harness-backed model editing for Copilot agent files, extending the existing harness-aware language features.
Changes:
- Resolves model catalogues and runtime identifiers for matching harnesses.
- Adds model-specific completions, hovers, and diagnostics.
- Tests catalogue selection, aliases, pending discovery, and reasoning effort.
Review effort: Balanced
Martin Aeschlimann (aeschli)
marked this pull request as ready for review
October 21, 2026 07:39
Martin Aeschlimann (aeschli)
marked this pull request as draft
October 21, 2026 07:40
Preserve per-harness capabilities, use provider-owned readiness, recognize agent-host BYOK copies, and retain mixed-case canonical model IDs. Refs #342881 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Refresh BYOK model rows only when their enablement changes or the bridge reports new models, preventing readiness metadata updates from republishing unchanged catalogues. Refs #342881 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…pilot-models-review
Select the first available model from custom agent model arrays before handing configuration to the Copilot SDK, which currently accepts only a scalar model. Preserve fail-open behavior when no catalogue is available. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds provider-backed Copilot model editing for
*.agent.mdfiles on top of #343021.ILanguageModelsServiceusing harness descriptors andtargetChatSessionType.target: github-copilotoverride when the active harness differs.(copilot)and(auto)aliases;Name (agent-host-copilotcli)qualification, which the runtime rejects.This draft PR is stacked on #343021 and addresses the model portion of #342881 / #342854.
Testing
npm run build-fast -- --client-only— passednpm run typecheck-client— passed.\scripts\test.bat --run src/vs/workbench/contrib/chat/test/browser/promptSyntax/languageProviders/promptHeaderAutocompletion.test.ts --run src/vs/workbench/contrib/chat/test/browser/promptSyntax/languageProviders/promptHovers.test.ts --run src/vs/workbench/contrib/chat/test/browser/promptSyntax/languageProviders/promptValidator.test.ts— passed, 292 tests