{{ message }}
Repository navigation
Fix incomplete Mission Control sandbox session discovery - #341823
Merged
Osvaldo Ortega (osortega) merged 2 commits intoOct 15, 2026
Merged
Osvaldo Ortega (osortega) merged 2 commits into
Osvaldo Ortega (osortega) merged 2 commits into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Follow every discovery page, recognize managed sandbox environments when compute metadata is missing, and report exclusion reasons without filtering by agent slug. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No blocking defects were identified; targeted regression coverage supports the changes while existing discovery safeguards remain intact.
0 open findings
What changed in this PR
Fixes incomplete GitHub Cloud session discovery in the Agents Window while keeping the feature opt-in.
Changes:
- Removes the pagination ceiling and recognizes sandbox tasks independently of agent slug.
- Adds filtering diagnostics and regression coverage.
- Makes Windows launcher Node selection deterministic.
🧠 Review effort: Balanced
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Osvaldo Ortega (osortega)
marked this pull request as ready for review
October 15, 2026 16:51
Osvaldo Ortega (osortega)
approved these changes
Oct 15, 2026
Osvaldo Ortega (osortega)
enabled auto-merge (squash)
October 15, 2026 16:57
Justin Chen (justschen)
approved these changes
Oct 15, 2026
Don Jayamanne (DonJayamanne)
approved these changes
Oct 15, 2026
Osvaldo Ortega (osortega)
disabled auto-merge
October 15, 2026 17:11
Osvaldo Ortega (osortega)
merged commit Oct 15, 2026
1324d5a
into
microsoft:main
37 of 38 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix missing GitHub Cloud sessions in the Agents Window:
managed-sandboxcurrent environment. Continue rejecting explicitly non-sandbox compute and tasks without usable session/environment bindings.The experimental cloud setting remains off by default. It was enabled only in the isolated development profile used for reproduction.
Validation
npm run build-fast -- --client-only— passed..\scripts\test.bat --run src\vs\workbench\contrib\chat\test\browser\remoteAgentHost\cloudSandboxApiService.test.ts --reporter dot— passed, 197 tests.npm run eslint -- src\vs\workbench\contrib\chat\browser\remoteAgentHost\cloudSandboxApiService.ts src\vs\workbench\contrib\chat\test\browser\remoteAgentHost\cloudSandboxApiService.test.ts— passed.git diff --check— passed before committing.chat.agentHost.cloudSandbox.enabled, rebuilt, and reloaded. Complete discovery increased from 56 to 627 sessions after adding the managed-environment fallback; confirmed the previously missing chat in both discovery logs and the UI. Full pagination scanned approximately 7,140 tasks without truncation.How to Test
chat.agentHost.cloudSandbox.enabledand optionally set the log level to Debug.managed-sandboxcurrent environment remain discoverable when their task summary omits compute metadata or uses a different agent slug.[CloudSandboxApi] Discovery filteringsummaries and per-task exclusion reasons inrenderer.log.No linked issue; investigated from a live missing-session report.