{{ message }}
Repository navigation
fix: sort terminal type-ahead latencies numerically - #341303
Merged
Connor Peet (connor4312) merged 1 commit intoOct 13, 2026
Merged
Connor Peet (connor4312) merged 1 commit into
Connor Peet (connor4312) merged 1 commit into
Conversation
Contributor
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused fix is correct and the regression test would fail without it.
0 open findings
What changed in this PR
Fixes terminal type-ahead latency statistics by ensuring numeric ordering.
Changes:
- Sorts recorded latencies numerically.
- Adds regression coverage for mixed-digit latency values.
🧠 Review effort: Balanced
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Connor Peet (connor4312)
enabled auto-merge
October 13, 2026 15:06
Anthony Kim (anthonykim1)
approved these changes
Oct 13, 2026
Sandeep Somavarapu (sandy081)
approved these changes
Oct 13, 2026
Connor Peet (connor4312)
merged commit Oct 13, 2026
2e086c5
into
microsoft:main
55 of 56 checks passed
yuki nakano (yuki-nakano-520)
deleted the
fix/typeahead-latency-numeric-sort
branch
October 13, 2026 22:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #341302
Problem
PredictionStats.latencysorted an array of numbers with.sort()and no compare function, so the latencies were ordered as strings.min,medianandmaxwere wrong whenever the recorded latencies had a different number of digits. For example, latencies of 5ms, 50ms and 200ms were reported asmin: 200, median: 5, max: 50.These values are used to decide whether local echo predictions are shown (the median is compared against
terminal.integrated.localEchoLatencyThreshold) and are sent in theterminalLatencyStatstelemetry event.Changes
sortinPredictionStats.latency.How to test
Run the unit tests:
or on macOS/Linux:
The new test
sorts latencies numericallyfails without the fix and passes with it. I have not verified the change in the UI, because it requires controlling the terminal latency.