Allow retrying pending Copilot connectors by pwang347 · Pull Request #341081 · microsoft/vscode · GitHub
Skip to content

Allow retrying pending Copilot connectors - #341081

Merged
Paul (pwang347) merged 3 commits into
microsoft:mainfrom
pwang347:fix/copilot-connector-pending-retry
Oct 13, 2026
Merged

Paul (pwang347) merged 3 commits into
microsoft:mainfrom
pwang347:fix/copilot-connector-pending-retry

Conversation

@pwang347

@pwang347 Paul (pwang347) commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #341065
Fixes #341088

Summary

  • allow a Copilot Connector left in a remote pending state after interrupted or cancelled authorization to expose its existing retry path
  • preserve deduplication for locally active connection operations
  • add focused state/action tests and deterministic pending-connector fixtures backed by the production UI and install service

Validation

  • ./scripts/test.sh --reporter dot --run src/vs/workbench/contrib/chat/test/browser/aiCustomization/connectorPresentation.test.ts --run src/vs/workbench/contrib/chat/test/browser/aiCustomization/customizationMarketplaceInstallService.test.ts --run src/vs/workbench/contrib/chat/test/browser/aiCustomization/embeddedMarketplaceDetail.test.ts — passed, 178 tests
  • npm run typecheck-client — passed
  • changed-file ESLint — passed
  • all four dark/light pending-connector fixture variants rendered without fixture errors
  • complete production-path UI probe passed:
    • connector detail: Connection pending + Try Again + 0 calls → guarded in-flight retry + 1 call → Connected + Disconnect + 1 call
    • Discover: orphaned remote pending + Connect + 0 calls → busy/disabled Connecting… + 1 call → Disconnect + 1 call

UI evidence

The attached videos are ordered as follows:

  1. Before: the pending connector exposes only Unavailable and cannot retry authorization.
  2. After: six asserted chapters cover both recovery surfaces:
    • the connector detail exposes Try Again;
    • Try Again is guarded while its single connector call is in flight;
    • the connector reaches Connected/Disconnect;
    • Discover recovers the post-cancel state with Connect;
    • Discover shows busy/disabled Connecting… while its single connector call is in flight;
    • Discover reaches Disconnect without a duplicate call.
issue-341065-before.mp4
issue-341065-after.mp4

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings October 12, 2026 15:32

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The targeted behavior is correctly implemented and covered by focused state, action, and UI tests.

0 open findings

What changed in this PR

Enables retrying Copilot Connectors stranded in a remote pending state while retaining local operation deduplication.

Changes:

  • Exposes retry actions for pending connectors.
  • Adds focused presentation and installation tests.
  • Adds a deterministic pending-connector fixture.
File Description
connectorPresentation.ts Maps pending connectors to retry actions.
connectorPresentation.test.ts Tests retry presentation and detail behavior.
customizationMarketplaceInstallService.test.ts Tests pending retries and unavailable states.
aiCustomizationManagementEditor.fixture.ts Adds pending-connector visual coverage.

🧠 Review effort: Balanced


💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@pwang347
Paul (pwang347) marked this pull request as ready for review October 13, 2026 00:04
@pwang347
Paul (pwang347) enabled auto-merge (squash) October 13, 2026 00:04
@pwang347
Paul (pwang347) merged commit 383dd2e into microsoft:main Oct 13, 2026
35 checks passed
@vs-code-engineering vs-code-engineering Bot added this to the 1.143.0 milestone Oct 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Testing: Canceling connector install results in permanent unavailable state Unrecoverable state: Failed to add MCP via Copilot Connectors

3 participants