{{ message }}
Repository navigation
agentHost: enable SDK skill installation - #340762
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused implementation consistently enables the required runtime gates and includes appropriate regression coverage.
0 open findings
What changed in this PR
Enables SDK-managed Skill discovery and installation in Agent Host sessions.
Changes:
- Enables catalog search and Skill installation flags for hidden, created, and resumed sessions.
- Updates launcher and agent tests to verify the flags.
🧠 Review effort: Balanced
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Paul (pwang347)
marked this pull request as ready for review
October 13, 2026 03:22
Paul (pwang347)
enabled auto-merge (squash)
October 13, 2026 03:22
Bhavya U (bhavyaus)
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #339896.
Summary
Agent Finder now returns materialized Skills through the SDK, but VS Code sessions did not enable the runtime gates required to install them. This change:
CATALOG_SEARCHandAGENT_FINDER_SKILL_INSTALLfor the hidden customization policy sessionThis does not add a VS Code setting or policy. Model-visible catalog tools remain separately gated by
DISCOVER_RESOURCES.Validation
./scripts/test.sh --reporter dot --run src/vs/platform/agentHost/test/node/copilotSessionLauncher.test.tscopilotSessionLauncher.test.tsandcopilotAgent.test.ts(100 tests)./scripts/test-integration.sh --run src/vs/platform/agentHost/test/node/e2e/providers/copilotAgentHostE2E.integrationTest.tsnpm run typecheck-clientnpm run hygienenpm run valid-layers-checkCOPILOT_HOME: search for an installable Skill, review and install through the SDK, verify receipt-owned installed state, then uninstall through the SDK (2/2)