nes: Add prompt template which enables only low/medium eagerness modes by bstee615 · Pull Request #340404 · microsoft/vscode · GitHub
Skip to content

nes: Add prompt template which enables only low/medium eagerness modes - #340404

Merged
Ulugbek Abdullaev (ulugbekna) merged 3 commits into
microsoft:mainfrom
bstee615:bensteenhoek-microsoft-hybrid-eagerness-prompt
Oct 12, 2026
Merged

nes: Add prompt template which enables only low/medium eagerness modes#340404
Ulugbek Abdullaev (ulugbekna) merged 3 commits into
microsoft:mainfrom
bstee615:bensteenhoek-microsoft-hybrid-eagerness-prompt

Conversation

@bstee615

@bstee615 Benjamin Steenhoek (bstee615) commented Oct 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Member
  • Adds PatchBased02UnifiedEagernessLowMedium, which enables the aggression prompt for the Low/Medium eagerness modes but uses default timing-based eagerness for the High eagerness mode.

Testing config:

    "github.copilot.chat.inlineEdits.xtabProvider.modelConfiguration": {
        "modelName": "copilot-nes-pandia-25-2-950-ppe",
        "promptingStrategy": "patchBased02UnifiedEagernessLowMedium",
        "includeTagsInCurrentFile": false
    },

Copilot AI balanced review requested due to automatic review settings October 8, 2026 00:04
Copilot AI reviewed Oct 8, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The strategy is consistently wired through configuration, prompt generation, response handling, timing behavior, and focused tests.

0 open findings

What changed in this PR

Adds an NES unified patch strategy that uses prompt-based eagerness for low/medium modes and timing-based behavior for high mode.

Changes:

  • Adds and validates the new prompting strategy.
  • Selects prompt- or timing-based eagerness by resolved level.
  • Adds prompt, configuration, and integration coverage.
File Description
xtabPromptOptions.ts Defines and configures the strategy.
promptCrafting.ts Generates level-specific prompts.
xtabProvider.ts Applies level-aware timing behavior.
xtabPromptOptions.spec.ts Tests configuration and classification.
promptCrafting.spec.ts Tests generated eagerness prompts.
xtabProvider.spec.ts Tests integrated prompt/timing behavior.

🧠 Review effort: Balanced

Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.

@bstee615
Benjamin Steenhoek (bstee615) marked this pull request as ready for review October 8, 2026 20:02
@bstee615

Benjamin Steenhoek (bstee615) commented Oct 8, 2026

Copy link
Copy Markdown
Member Author

CC Ulugbek Abdullaev (@ulugbekna)

@vs-code-engineering

vs-code-engineering Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

@bstee615 @ulugbekna
Add hybrid low/medium prompt and high timing eagerness
a720457 
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 74014a36-fb18-401e-a310-a96ddfded152
@bstee615 @ulugbekna
Remove CONTRIBUTING changes from hybrid eagerness work
fd7e2c9 
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 74014a36-fb18-401e-a310-a96ddfded152
@ulugbekna
Ulugbek Abdullaev (ulugbekna) force-pushed the bensteenhoek-microsoft-hybrid-eagerness-prompt branch from 8470b60 to fd7e2c9 Compare October 11, 2026 19:46
connor4312
Connor Peet (connor4312) approved these changes Oct 12, 2026
View reviewed changes

@connor4312 Connor Peet (connor4312) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No actionable P1 or P2 findings identified in the reviewed changes.

Written by Connor's agent running GPT-6.1 Sol

@ulugbekna
Ulugbek Abdullaev (ulugbekna) merged commit fe8fcbc into microsoft:main Oct 12, 2026
35 checks passed
@vs-code-engineering vs-code-engineering Bot added this to the 1.143.0 milestone Oct 12, 2026
@ulugbekna Ulugbek Abdullaev (ulugbekna) added ~release-cherry-pick Trigger: cherry-pick this PR to the latest release branch and removed triage-needed labels Oct 12, 2026
@vs-code-engineering vs-code-engineering Bot mentioned this pull request Oct 12, 2026
Merged
@vs-code-engineering vs-code-engineering Bot added release-cherry-pick Automated cherry-pick between release and main branches and removed ~release-cherry-pick Trigger: cherry-pick this PR to the latest release branch labels Oct 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@connor4312 Connor Peet (connor4312) connor4312 approved these changes
@ulugbekna Ulugbek Abdullaev (ulugbekna) ulugbekna approved these changes
@alexr00 Alex Ross (alexr00) alexr00 approved these changes

Assignees

@rzhao271 Raymond Zhao (rzhao271)

Labels

release-cherry-pick Automated cherry-pick between release and main branches

Projects

None yet

Milestone

1.143.0

Development

Successfully merging this pull request may close these issues.

6 participants

@bstee615 @connor4312 @ulugbekna @alexr00 @rzhao271