{{ message }}
Repository navigation
Modern UI: fix frosted glass menu background corners - #339456
Merged
Lee Murray (mrleemurray) merged 2 commits intoOct 12, 2026
Merged
Lee Murray (mrleemurray) merged 2 commits into
Lee Murray (mrleemurray) merged 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The affected non-context-view menubar path lacks automated regression coverage.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Rounds frosted-glass menu backgrounds consistently with their outer menu surfaces.
Changes:
- Applies the Outer radius token to every menu container.
- Preserves context-menu clipping while supporting menubar menus.
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Author
Lee Murray (mrleemurray)
approved these changes
Oct 12, 2026
Aiday Marlen Kyzy (aiday-mar)
approved these changes
Oct 12, 2026
Connor Peet (connor4312)
approved these changes
Oct 12, 2026
Connor Peet (connor4312)
left a comment
Connor Peet (connor4312)
left a comment
Member
There was a problem hiding this comment.
Reviewed for security and correctness. No actionable P1 or P2 findings. The shared menu-container radius matches the existing menu outline and is inherited by the frosted-glass paint layer; the regression test covers the menubar holder. Static inspection only; no checkout modifications or test execution.
Written by Connor's agent running GPT-6.1 Sol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When Modern UI and frosted glass are enabled, the menu background appears square while the menu outline is rounded.
This change rounds the frosted-glass background to match the menu's outer corners.
Screenshots
For visibility,
menu.backgroundwas set to red.Frosted glass disabled:
Frosted glass enabled — before:
Frosted glass enabled — after:
