{{ message }}
Repository navigation
sessions: Stabilize approval row height during sticky scrolling - #338210
Merged
2 commits merged intoOct 18, 2026
Merged
2 commits merged into
2 commits merged into
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused CSS fix addresses the documented feedback loop and is covered by representative regression tests.
Review effort: Balanced
Findings: None
What changed in this PR
Stabilizes Sessions approval rows during sticky scrolling by preventing asynchronous code-block placeholders from inheriting inflated row heights.
Changes:
- Sets approval-row line height to the existing 18px calculation.
- Adds four regression scenarios covering layouts, command lengths, and repeated sticky scrolling.
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Alexandru Dima (alexdima)
added a commit
that referenced
this pull request
Oct 18, 2026
…scrolling) Merge rksharma-owg's head 8c82d12 so their commits land with this fix. Conflict resolution: keep a single line-height declaration on .session-approval-row with the more detailed comment, keep main's listService import, and use their four sticky-scroll regression tests in place of the narrower single-case test, which they cover. Co-authored-by: rksharma-owg <rajesh.sharma@owasp.org> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Alexandru Dima (alexdima)
closed this pull request by merging all changes
into
microsoft:main
in
2de8dcf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #338189
Approval code-block placeholders inherit the list row's line-height while Markdown rendering completes asynchronously. Sticky-scroll measurement can then count each placeholder line as an entire row and propagate the inflated height back to the main list.
Give the shared approval container the 18px line-height already used by approval-height calculation. Add four regression cases using the real Sessions list and code-block renderer, covering compact/normal layouts, one/three command lines, expanded child chats, and repeated sticky scrolling. All four fail with the original CSS and pass with this change.
Validation on
8c82d12f4277d62c6ac89fab11adf08c9f626683:Fork preflight: browser, static and fixture checks, Electron checks. The workflows assert the tested commit; their configuration is separate from this PR.