{{ message }}
Repository navigation
Fix/issue 337524 multidiff order - #337565
Merged
Dmitriy Vasyura (dmitrivMS) merged 10 commits intoOct 5, 2026
Merged
Dmitriy Vasyura (dmitrivMS) merged 10 commits into
Dmitriy Vasyura (dmitrivMS) merged 10 commits into
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The regression test has a critical type incompatibility and a cross-platform assertion issue.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Aligns SCM multi-diff ordering with the SCM file list’s path-based order.
Changes:
- Sorts resources using
comparePaths. - Adds regression coverage for resource ordering.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Author
|
@microsoft-github-policy-service agree |
Member
|
Ürem Sancaktutan (@codelovingcat), thank you very much for your contribution! |
Ladislau Szomoru (lszomoru)
previously approved these changes
Sep 27, 2026
roblourens
previously approved these changes
Sep 27, 2026
Dmitriy Vasyura (dmitrivMS)
enabled auto-merge (squash)
September 27, 2026 18:40
Collaborator
Bhavya U (bhavyaus)
previously approved these changes
Sep 27, 2026
Dmitriy Vasyura (dmitrivMS)
requested changes
Sep 28, 2026
Dmitriy Vasyura (dmitrivMS)
left a comment
Dmitriy Vasyura (dmitrivMS)
left a comment
Collaborator
There was a problem hiding this comment.
build break
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Ladislau Szomoru (lszomoru)
dismissed stale reviews from Bhavya U (bhavyaus), roblourens, and themself
via
September 28, 2026 07:36
fda6c34
Ladislau Szomoru (lszomoru)
requested a review
from Dmitriy Vasyura (dmitrivMS)
October 5, 2026 09:02
Dmitriy Vasyura (dmitrivMS)
approved these changes
Oct 5, 2026
Giuseppe Cianci (Giuspepe)
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The SCM file list and the multi-diff editor can display the same changed files in different orders.
The SCM file list sorts resources by path, while the SCM multi-diff source uses the resource group order directly. This can make corresponding files appear at different positions in the two views.
This change makes the SCM multi-diff source use the same path ordering as the SCM file list.
Related Issue
Fixes #337524
How to Test
Added a regression test covering the reported file ordering using:
githubServer.tsenv.tsgithubUri.tsThe test verifies that SCM multi-diff resources are returned in path order.
Changes
comparePaths.