{{ message }}
Repository navigation
terminal: Stabilize persistence replay smoke tests - #336677
Merged
Dmitriy Vasyura (dmitrivMS) merged 2 commits intoSep 18, 2026
Merged
Conversation
Wait for the finite producer before reconnecting, then verify both ordered replay and fresh live output without racing the two. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The reviewed test-only changes have no unresolved blocking issues.
Review effort: Lite (auto)
Findings: None
Note
Copilot is running an experiment and ran this review at Lite.
What changed in this PR
Stabilizes terminal persistence replay smoke tests by separating completed replay from subsequent live output.
Changes:
- Waits for producer completion before reconnecting.
- Focuses the restored terminal and emits a final live line.
- Validates the complete sequence strictly and removes the arbitrary delay.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Keep the producer alive in raw input mode and request the final output through stdin, preventing macOS prompt and Windows input-echo redraws from overwriting the replayed sequence. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Dmitriy Vasyura (dmitrivMS)
marked this pull request as ready for review
September 18, 2026 04:28
Dmitriy Vasyura (dmitrivMS)
enabled auto-merge (squash)
September 18, 2026 04:28
Dirk Bäumer (dbaeumer)
approved these changes
Sep 18, 2026
Dmitriy Vasyura (dmitrivMS)
deleted the
agents/fix-ci-test-failure-pull-323980
branch
September 18, 2026 06:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes microsoft/vscode-engineering#3893.
Summary
Stabilize the terminal persistence smoke tests introduced by #323980 by separating completed-output replay from subsequent live output:
Why
The Windows failure in Azure build 474799 captured
[21, 0, 1, ..., 99]: live output arrived before the replayed buffer. Local validation with retries disabled also reproduced a missing entry when live output raced replay.The macOS detach/attach trace also showed that replay was complete before a wrapped shell prompt redrew over entries 95–99. Keeping the producer alive avoids returning to that prompt; raw input additionally prevents Windows console input echo from overwriting replayed output.
This is a test-only change. It verifies replay and subsequent live delivery separately rather than relying on concurrent live/replay ordering; it does not change production behavior.
Validation